search

Dzoukr / CosmoStore

F# Event store for Azure Cosmos DB, Table Storage, Postgres, LiteDB & ServiceStack
MIT License
168 stars 21 forks source link

Lite DB for cosmo store. #14

Closed kunjee17 closed 4 years ago

kunjee17 commented 5 years ago

Hi @Dzoukr

Here is LiteDB cosmostore implementation. I was able to pass all tests but not without modifying JToken -> Obj. Again I don't know if all data is coming back is same as it should.

I keeping it in PR, and will see what we can do.

We gonna meet at FSharpex. May be we can do pair coding there. Even another Roman will be there as well, and confidently he also like ES. :)

Dzoukr commented 5 years ago

Hi @kunjee17,

thanks a lot! I'll pull it and have a look.

Dzoukr commented 5 years ago

Hey @kunjee17 I was thinking... what if I create special branch only for this feature (feature/lite-db) where we can both contribute and work on LiteDB be ready (+ we will keep master clean) and then you will create PR in master? I'd like to help (and I am glad for your work 🙏) but don't want to merge breaking changes in JToken -> obj so we could do it there for now?

Please, let me know.

kunjee17 commented 5 years ago

@Dzoukr oh not an issue. I just merge branch so you can have a look. I am open for your option.

It is just that I don't want to take the credit of your hard work (wonderful abstracted library and test cases) so I sent a merge request.

I also had two version of it (one with generic and one with obj ).

Just keep the WIP for now. I ll keep that in one way sync (master to this branch) for now. And will see what can be done later.

Dzoukr commented 5 years ago

No problem. I don't see it as any attempt to take my credit. I see it as you want to help to contribute and I am truly grateful for that! 🙏 I am looking forward to release LiteDB support as soon as it is ready with all the credits for your hard work, my friend. So lets work together to make it work, test, release, announce and celebrate on FSharpX! 😂

Dzoukr commented 4 years ago

Hi mate, please let me know whenever you feel I can merge your PR for LiteDB. I am checking regularly, but not daily so can easily miss it. :)

kunjee17 commented 4 years ago

@Dzoukr I ll update this with latest one soon. Sorry couldn't give time due to some medical conditions.

Dzoukr commented 4 years ago

No problem at all, mate! No worries, first thing first. Just wanted you know that I am not ignoring it, just need some final ping back from you, that's all. Get well soon!

kunjee17 commented 4 years ago

@Dzoukr finally LiteDB support is landed. It is good to go. If you merge this PR then #33 will be merged automatically. It is already included.

kunjee17 commented 4 years ago

I guess we can remove JToken from test. As we are passing them as parameter. But haven't look into it in details. BTW few more support is coming soon.

Dzoukr commented 4 years ago

Thanks mate!!! Going to check it and release soon! Thanks again!!!!