search

Dzoukr / Dapper.FSharp

Lightweight F# extension for StackOverflow Dapper with support for MSSQL, MySQL, PostgreSQL, and SQLite
MIT License
374 stars 35 forks source link

Enable Source Link #19

Closed randrag closed 3 years ago

randrag commented 3 years ago

Hi Roman,

I've made the changes, built it on my local machine, and tested that the sources are available to a project referencing the newer version.

It took me a while to figure out that I had to commit changes and push to the remote repo on Github before building and staging the nuget file, in order for Source Link to pick up the source code, since it fetches the source from the specific commit in the repo.

Hopefully this is satisfactory and closes #18.

Thanks again for a great library,

Roland

randrag commented 3 years ago

I will test and revert.

randrag commented 3 years ago

Hi Roman, it looks like it is sufficient to just add the nuget reference to the build section of the paket.dependencies file.

One side note is that I don't know where the PrivateAssets="All" goes in this scenario. In any case, the link seems to work fine from my machine.

Dzoukr commented 3 years ago

No problem Roland, I'll merge and add it. I found forki's comment about PrivateAssets here: https://github.com/fsprojects/Paket/issues/2951#issuecomment-354417950

Dzoukr commented 3 years ago

Thanks again, Roland. Will release soon!

Dzoukr commented 3 years ago

Aaaaaaaand released! In your Nuget feed soon.

randrag commented 3 years ago

Thank you, just ran paket update in our production project, and it works!