Dzoukr / Dapper.FSharp

Lightweight F# extension for StackOverflow Dapper with support for MSSQL, MySQL, PostgreSQL, and SQLite
MIT License
365 stars 35 forks source link

Left Join on Multiple Columns #43

Closed tskj closed 2 years ago

tskj commented 2 years ago

Is it possible to get this api for leftJoin as well?

Dzoukr commented 2 years ago

You mean this? https://github.com/Dzoukr/Dapper.FSharp#joins

Or can you elaborate on what exactly do you miss in LINQ API? 🤔

tskj commented 2 years ago

Sorry I should have been more clear maybe - or perhaps I didn't see it in the documentation. I want multiple column joins on jeftJoin, exactly the same as the new api for innerJoins!

table "A"
leftJoin "B" [ "A.x", "A.y"; "B.x", "B.y" ]
JordanMarr commented 2 years ago

That should be pretty easy to port over, right @TerenceHinrichsen?

TerenceHinrichsen commented 2 years ago

Most definitely, should be able to get it done fairly quickly.

tskj commented 2 years ago

Wow thanks, that's brilliant! When can I expect this to be available in a release?

Dzoukr commented 2 years ago

PR just released as v2.4.0, thanks @TerenceHinrichsen again for amazing work!

I think we can close this issue, right @tskj ?

tskj commented 2 years ago

This worked brilliantly, exactly what I needed, thank you so much for the quick execution!