Increased join limit from 2 to 4

Dzoukr / Dapper.FSharp

Lightweight F# extension for StackOverflow Dapper with support for MSSQL, MySQL, PostgreSQL, and SQLite

MIT License

374 stars 35 forks source link

Increased join limit from 2 to 4 #82

Closed 1eyewonder closed 1 year ago

1eyewonder commented 1 year ago

PR to address issue #66.

I added up to four joins to hopefully support the use case requested. Let me know if I missed anything or if you'd like something done differently and I'd be happy to help!

Changes include:

Updated join overrides
Updated tests
Updated readme - v3
Updated mssql connection string to allow me to connect 'out of the box'. If we want this reverted, let me know.

Dzoukr commented 1 year ago

Looks good, thanks for that! Btw, what was the issue with DateTime (I see you removed that field from tests)?

Dzoukr commented 1 year ago

You changed the old README file (it's for the previous version), but no problem, I'll quickly check anyway and will release soon.

Dzoukr commented 1 year ago

Just released. Great work! Thanks!