FEAT: Commons IP schema validation

E-ARK-Software / eark-validator

E-ARK Python Information Package validation library

Apache License 2.0

5 stars 3 forks source link

FEAT: Commons IP schema validation #60

Closed carlwilson closed 2 months ago

carlwilson commented 2 months ago

removed expansions of status enums; and
added a ruleId alias for validation rule_id.

carlwilson commented 2 months ago

LGTM, however why did you remove spaces from well and not well formed constants?

That's because they're incompatible with commons-ip which doesn't include spaces. I need compatibility to auto compare the results via a JSON deserialisation. Once we have compatibility we can talk about changes, but I can't change commons-ip.

carlwilson commented 2 months ago

Final time I promise @dockmd, this is now compatible with commons-ip JSON and the new validator rest service works.

carlwilson commented 2 months ago

@dockmd, I should have kept my mouth shut. Found another change to make to coerce a final value. I'll take a look at your suggestion about root and get a final commit up shortly. Looking to close this and merge to integrations ASAP as I can then get a test package out and an updated REST validator.