E-CAM / jobqueue_features

This library provides some useful decorators for dask_jobqueue. It also expands it's scope to include MPI workloads, including extending configuration options for such workloads and heterogeneous resources.
6 stars 3 forks source link

Concerning filtering kwargs in overriden Job class #90

Open AdamWlodarczyk opened 3 years ago

AdamWlodarczyk commented 3 years ago

During code tweaks (https://github.com/E-CAM/jobqueue_features/pull/78) due to some changes in dask-jobqueue 0.7.2 (https://github.com/dask/dask-jobqueue/pull/398/files#diff-2b72fb950d6946ee9e2a90af40d1668cb8a2d149b9609be158820257726b27c4L150) I made a functionality which filters kwargs which are valid for calling Job __init__ method.

I wonder if this approach, i.e. popping out all invalid kwargs before calling the super method, is alright or should we sanitize it all over the place before.