search

E-CAM / jobqueue_features

This library provides some useful decorators for dask_jobqueue. It also expands it's scope to include MPI workloads, including extending configuration options for such workloads and heterogeneous resources.
6 stars 3 forks source link

Ensure to connect to available port (fix: #97) #98

Closed AdamWlodarczyk closed 3 years ago

AdamWlodarczyk commented 3 years ago

If you think that it could be done better let me know. I'm not experienced with docker TBH.

MilBia commented 3 years ago

If we want to try to save the port 8888 (or one of the next) as a host it's nice approach. If we just want it to be any of host ports, we can just: "${SLURMCTLD_OUT_PORT}:8888" -> "8888" and save as our port variable result of following: docker port slurmctld 8888 | cut -d ":" -f2

ocaisa commented 3 years ago

I think we should do the same for port 8787, there is a chance this is also occupied on the host, we can then say

echo -e "\tOpen your browser at http://localhost:$port/lab/workspaces/lab (default Dask dashboard will be available at http://localhost:$daskport)"
AdamWlodarczyk commented 3 years ago

Thanks @MilBia – I think this is a better solution, though it yields some less organized port numbers like 32768. But that is why we print it out. Perfect :superhero:

MilBia commented 3 years ago

LGTM

ocaisa commented 3 years ago

Tested in my setup and worked fine, thanks @AdamWlodarczyk