search

E-Kuerschner / useAudioPlayer

React hooks for controlling audio on the web
MIT License
315 stars 35 forks source link

Error in the Readme, fade arg says second not ms #125

Closed theslantedroom closed 10 months ago

theslantedroom commented 10 months ago

Describe the bug in the read me and https://www.npmjs.com/package/react-use-audio-player

fade (from: number, to: number, duration: number) => void Fades the sound's volume level from the value of the first argument to the value of the second, over a number of seconds as set by the final argument

should be

fade (from: number, to: number, duration: number) => void Fades the sound's volume level from the value of the first argument to the value of the second, over a number of milliseconds as set by the final argument

E-Kuerschner commented 10 months ago

thanks for noticing this @theslantedroom! Do you mind putting up a PR for the fix? Happy to review/merge

theslantedroom commented 10 months ago

thanks for noticing this @theslantedroom! Do you mind putting up a PR for the fix? Happy to review/merge PR open!