search

E-Kuerschner / useAudioPlayer

React hooks for controlling audio on the web
MIT License
330 stars 36 forks source link

Resolves #39. Moves the position state to the provider #41

Closed humbkr closed 4 years ago

humbkr commented 4 years ago

Moves the position state to the provider so position-sensitive components are synchronized.

E-Kuerschner commented 4 years ago

Thanks for the PR, I'll review later this afternoon (central time) when I have a break in my day

humbkr commented 4 years ago

About tests what kind of tests do you want to add? I see a jest test for the player test and a cypress test for the playback, so you already have a non regression test.

E-Kuerschner commented 4 years ago

@humbkr I think it would be good to have a test that ensures the state returned from different useAudioPlayers is the same after a seek from one of them. I'm going to go ahead and merge for now as I plan on adding more tests myself in a maintenance release. Thanks for your work!