search

E-Kuerschner / useAudioPlayer

React hooks for controlling audio on the web
MIT License
315 stars 35 forks source link

Potential unnecessary re-renders #48

Closed E-Kuerschner closed 3 years ago

E-Kuerschner commented 3 years ago

Describe the bug https://github.com/E-Kuerschner/useAudioPlayer/blob/master/src/useAudioPlayer.ts#L28 restOptions will be a new reference on every render. The effect will run on every render. Just move line 20 inside the effect.