E-LeeSchaffer / money-manager

Capstone Project: Money Manager
https://money-manager-flax.vercel.app
1 stars 0 forks source link

Delete Transaction #3

Closed melanie-adler closed 1 month ago

melanie-adler commented 2 months ago

Value Proposition

As a user

I want to delete incorrect transactions,

so that I can maintain an accurate and organised transactions list.

Description

Image

Acceptance Criteria

Tasks

F-Kirchhoff commented 1 month ago

in your tasks its missing how you achieve the deletion of the element. Please give better names than just Button.

NikRoe commented 1 month ago

You won't be submitting your Button component, but it will most likely can be clicked and that click should trigger the handleDelete.

Your last Task mentions isLoading and error, you work with those two things when using useSWR, which is not the case yet for your application. Unless I am mistaken.

I recommend removing the last bullet point and updating the rethink how the handleDelete in your Button component will actually be triggered.

NikRoe commented 1 month ago

👍 LGTM