E1337Kat / cyberpunk2077_ext_redux

A rework of the cyberpunk vortex extension
GNU General Public License v3.0
35 stars 17 forks source link

Redscript path mangling can cause game to flatline #358

Open Bladehawke opened 1 year ago

Bladehawke commented 1 year ago

Describe the bug When two redscript mods with the same name but different paths exist, the game will flatline at the game loading step. This can happens hen a mod with no top level folder under r6/scripts is patched by another mod on the same page. In the case below, the main mod file is called "Darks Night City Marketplace" and the patch file is called "Darks Night City Marketplace - Sasquatch Replacement" This places the file z27_aterlier_store_tygerclaw_iconic.reds in r6/scripts/modfilename/ in staging for both mods resulting in the crash.

To Reproduce Steps to reproduce the behavior:

  1. Download both files using Vortex from this mod
  2. Install with Vortex
  3. Launch game
  4. Continue your existing game
  5. See error

Expected behavior Path munging done based on the mod page name rather than the downloaded filename would obviate this issue and instead pop up a file conflict (which the user can fix)

Screenshots If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):

Additional context Add any other context about the problem here.

E1337Kat commented 1 year ago

One issue is that we don't necessarily know the mod page name at install time. It does bring up an interesting issue though.