search

E1337Kat / cyberpunk2077_ext_redux

A rework of the cyberpunk vortex extension
GNU General Public License v3.0
34 stars 17 forks source link

feat: allow users to see redmod deploy logs by adding pause #377

Open huynhj93 opened 8 months ago

huynhj93 commented 8 months ago

Hello!

When we use this extension and deploy RedMods, a command prompt pops up to see the deployment logs for redmod.exe. This is great when the build is not cached and you can actually tail the logs. However, when the RedMod deployment fails, and the deploy is cached, then the command prompt logs disappears almost immediately! This makes it hard to debug, so I'm suggesting to have the command prompt not automatically exit. This is a draft pull request based on: https://stackoverflow.com/a/60053224, I have not tested this functionality and need some guidance on how to refine this. Ideally, we only want this if the deploy fails!

huynhj93 commented 8 months ago

After further investigating, we might need to use the cmd -k, and then & pause, see: https://superuser.com/a/1590052

huynhj93 commented 8 months ago

Hopefully this works via the vortex api, I'm not sure if it'll have permissions to cmd.exe but i know it works locally! Screenshot 2024-01-12 103318-2

E1337Kat commented 7 months ago

interesting. I will play around with this and see what I can do. Alternatively I might be able to capture the logs from the command and just keep them if the command failed. More alternatively, I think there is an actual log file that could be read after the command has ran that would have the results in it. I don't know where the log is off the top of my head and am on my work PC right now so I can't check, but maybe that is he route to look at.

effs commented 7 months ago

The log is in tools/bin/redmod/redmod.log, though since there's no time stamps, it's not optimal.

I don't remember if the new command logic enables us to capture the stdout/stderr, I think that change was left out since modlist kinda worked around the problem? But I think that's the better way, that way we can decide what to do.

This would solve the issue for some users, so it'd be a good addition, but others don't want it so we'd need an option either way..