search

E1Bos / VALocker

VALocker: Valorant Agent Instalocker. Automate VALORANT agent selection with ease.
MIT License
11 stars 1 forks source link

[BUG] Fast Mode Timings crashes when called with .get #9

Closed LaquanFinema closed 2 months ago

LaquanFinema commented 2 months ago

Describe the bug The exe fails to run and returns an error as shown below.

To Reproduce Every time I double click to run ther executable, nothing happens for a second and then the error window appears.

Expected behavior In previous versions the ui would open when the exe was run

Screenshots The error window: VALocker

The line that I believe is refferenced in the error: image

Program Information:

Additional context Pretty sure this is a software issue but it could be my fault, hope the above was helpful.

E1Bos commented 2 months ago

Thank you for the report,

I've started investigating the issue and I think I've found the root cause. I'll respond with more details when I've fully fixed the issue.

E1Bos commented 2 months ago

Hello, I think I've solved the issue.

The issue came from the Settings file not having its version (1.0.1) updated when I added the new fastModeTimings dict. It would pass the update check, and the version check, and since fastModeTimings was previously a list, it would return a valid value so it wouldn't be replaced with the default "If all else fails" value. this fix has been rolled out and should be fixed for all VALocker 2.1.3.

E1Bos commented 2 months ago

I just released VALocker v2.1.4. I won't be able to prevent human issues like this from occurring in the future, but it has made me more mindful and aware of it going forward.

I have implemented a feature to force-check for updates when a file does not meet the required version. This should help prevent issues where updating the file would solve it but aren't checked for because of the minimum wait time between updates. I've also solved files not being read back into memory correctly by the file manager when a file is updated.

Thank you for the bug report, I appreciate you putting in the time to help me improve my program. I'm sure there are some nasty little bugs still hiding, but you helped catch one I missed! Please let me know if you're still experiencing issues.