E1iTeDa357 / docker-homeseer4

MIT License
8 stars 10 forks source link

Simple changes / fixes #5

Open bravobravo-au opened 3 years ago

bravobravo-au commented 3 years ago

Hi,

There are a few things that I have been working on to improve this container. I'm currently testing the larger changes but here are some simpler ones.

Added to list of installed OS packages installed via apt-get

locales

Added these commands to the RUN command to setup the locale and timezones

&& locale-gen en_US en_US.UTF-8 pl_PL pl_PL.UTF-8 \
&& dpkg-reconfigure locales \

I also removed

&& rm -rf /var/lib/apt/lists/* \

As this makes the container harder to use if you import it in another container.

I'm currently testing running HomeSeer as a user homeseer and not root. So far this is working (less than 8 hours) but needs more testing. I'll submit a pull request if people are interested. I also have a docker-compose file that I use with macvlan settings that could be useful for others attempting to do the same thing. I've also added Timezone configuration to the container. At present I have hardcoded

&& ln -snf /usr/share/zoneinfo/Australia/Melbourne /etc/localtime \
&& echo Australia/Melbourne > /etc/timezone \

But should be able to make it an environment variable.