search

E2OpenPlugins / e2openplugin-Foreca

Weather forecast
13 stars 23 forks source link

Some localizations are missing #62

Closed Orlandoxx closed 1 year ago

Orlandoxx commented 1 year ago

Hello,

is it possible to make : Feels Like:, Precip chance: and Humidity: translatable ? Thank you !

jbleyel commented 1 year ago

Is this fixed?

Orlandoxx commented 1 year ago

Unfortunately not.

MrServo commented 1 year ago

OK! I will overwork this issue in the plugin... ADDENDUM: Information texts like 'Weather description', 'Feels like', 'Probability of precipitation' and 'Relative humidity' are part of the localisation of provider 'Forcea'! Depending on your country settings in Enigma2, the plugin picks them up and sends them to 'Foreca'. If the country abbreviation is supported there, then 'Foreca' delivers the desired localized strings. If the localization does not work with your country code set in Enigma2, please tell me your country and I will try to map this country code to a Foreca known code.

Orlandoxx commented 1 year ago

Finland

MrServo commented 1 year ago

You can try it for your own. Copy this string into your browser and play around with the country settings. In this example it is 'de' for Germany. Try 'fr' for France and then try 'fi' or other possibilities. In case you got it, please tell me in order to map the E2-setting to 'Foreca'-setting

https://www.foreca.hr/Germany/Berlin?lang=de&details=20230328&units=metrickmh&tf=24h

Orlandoxx commented 1 year ago

Ok, I'm back at home friday. Then I can make tests what is needed.

Orlandoxx commented 1 year ago

Hello,

with https://www.foreca.hr/Germany/Berlin?lang=fi&details=20230328&units=metrickmh&tf=24h everything is in english.

with https://www.foreca.fi/Germany/Berlin?lang=fi&details=20230328&units=metrickmh&tf=24h everything is in finnish.

jbleyel commented 1 year ago

That's funny because Finnish is not in the list of supported languages.

Bild 30 03 23 um 18 37

MrServo commented 1 year ago

Thanks for your investigations. I will modify plugin on order to use the Finnish URL in case of language settings "Finland"...

Orlandoxx commented 1 year ago

Thanx !

MrServo commented 1 year ago

The Finnish homepage 'www.foreca.fi' (JSON based) is completely different from the regular one (HTML-based). That's why it's just too much effort for me to implement a separate version exclusively for the Finnish homepage. Unfortunately, I can't go exclusively through the Finnish homepage (JSON based) either because it doesn't support other languages, it then switches to a different URL (HTML-based) when I change languages.

Orlandoxx commented 1 year ago

I understand, no problem. Thank you for clearing it out.

P.S. Can you merge my commit ? Also copy it to python3 branch ?

MrServo commented 1 year ago

It's already done. ;) In case the FORECA-plugin will not work one day (is foreseeable), we will change the plugin to JSON as well and then it will probably work with the Finnish homepage as well. Anyway, we won't lose sight of that... ;) If you like, you can close this issue here.

Orlandoxx commented 1 year ago

Wow ! Thank you very much. I will close this issue.