search

E2OpenPlugins / e2openplugin-OpenWebif

GPL Web Interface for e2stabs
GNU General Public License v3.0
204 stars 227 forks source link

Stream buttons not inserted for 4097 stream type (classic i/f) #1415

Open privatissimo opened 2 years ago

privatissimo commented 2 years ago

When viewing a mkv recording/file, using classic interface the stream buttons on the left top of the page (osdicon div) are not inserted/shown when stream type is 4097, it works using modern interface. Looking at and vti-responsive.js and openwebif.js, the issue is in line 771 of openwebif.js, where

currently "} else if (sref.indexOf("1:0:0") !== -1) {"

should be "} else if ( (sref.indexOf("4097:0:0") !== -1) || (sref.indexOf("1:0:0") !== -1)) {"

jbleyel commented 2 years ago

This is not so easy as you think. Srefs starting with 4097 are normally external stream links (IPTV) and not local files.

privatissimo commented 2 years ago

If so, why that's how is implemented and works in modern UI?

jbleyel commented 2 years ago

The modern ui is also wrong here.

wedebe commented 2 years ago

If so, why that's how is implemented and works in modern UI?

The modern header where the OSD was almost completely rewritten (very) recently

jbleyel commented 2 years ago

If so, why that's how is implemented and works in modern UI?

The modern header where the OSD was almost completely rewritten (very) recently

And if this is finished, we can port this to the classic UI.

wedebe commented 2 years ago

The modern ui is also wrong here.

I believe I process for URL safety with the channel name and event name, but may have overlooked files