search

E2OpenPlugins / e2openplugin-OpenWebif

GPL Web Interface for e2stabs
GNU General Public License v3.0
205 stars 226 forks source link

Cosmetic #214

Closed ims21 closed 9 years ago

ims21 commented 9 years ago

1) Top on main screen - bottom is cropped box name ( chars as ... p,g,y ...)

2) Blue bar with On/Off button and where is actual service - when is larde EPG, then text goes bottom of tihs blue box.

Invention - to add button for streaming actual service to this blue bar (near On/Off button) ?

jbleyel commented 9 years ago

Could you please take a screenshot where i can see what you mean. Thanks

ims21 commented 9 years ago

owif ad 1) only in "Normal size" (Firefox, 1366*768), on next sizes it is ok (Ctrl +/-) ad 2) still

Schimmelreiter commented 9 years ago

This is actually a browser issue:

Either Firefox or Chrome is using the wrong height of a font:

Firefox: image

Chrome: image

See the letters reside on the virtual line at 70px from top

I can't check all screen resolutions and browser but I guess this https://github.com/E2OpenPlugins/e2openplugin-OpenWebif/commit/6feab15ab5e17098391723c612617dd5a71ada62 should fix 1)

2) was fixed in https://github.com/E2OpenPlugins/e2openplugin-OpenWebif/commit/c7cb8d7045bd3bc26dcbd2f08a75ab97ed4468bf

ims21 commented 9 years ago

ad 2) it was not problem in description ! Enought, when Y of windows for text will little bit top and all will be ok.

ims21 commented 9 years ago

There are displayed 3 rows (1 + 2). 3rd row is ALWAYS over blue bar. It is not in description. a) move text little bit top or b ) resize blue bar bottom

Schimmelreiter commented 9 years ago

The description never gets that long for me here and it looks ugly to move the text up, making the visual contrast of the status bar to the header disappear because it all gets filled up with text.

This is what it is supposed to look like: image

If we just move everything up, the symetry between top and bottom will get lost, making things look ugly. The potential problem with the space came up when we merged a change which not only showed start and end time, title and short description but also the long description (As some XMLTV sources do not contain a proper shortdesc).

That's a "garbage in - garbage out" problem.

ims21 commented 9 years ago

Its is funny reading about "wrong" visual ... why cannot be added some pixels for blue bar ?

When it will be in 2 lines, it is more ugly and then will be impossible more add to this bar "Stream actual service" button.

Schimmelreiter commented 9 years ago

Why add more space when there isn't more content to be shown?

I don't get your problem: The status bar was sized for service name, start + end time, title and short description. It fits perfectly for that. There is no need to waste plenty of free space around it.

The cosmetic glitches appeared after the long description (Which can become really long ...) was added to work around the lack of short descriptions inside XMLTV sourced EPG.

So that a problem inside XMLTV data in the end, because it just lacks what real EPG can provide: The short description.

I don't see any reason to break displaying proper data even more just to satisfy the needs of bad data.

ims21 commented 9 years ago

I think, you do not respect, that length of "short description" is 256 characters ! If your providers do not using it whole, it not means, that it will be limited for all others.

ghost commented 9 years ago

@ims21 I'll add the streaming buttons/icons today

ims21 commented 9 years ago

Thanks. Finally some good news.

Schimmelreiter commented 9 years ago

I really don't get your problem.

I've modified the css in a way that the text gets condensed on tiny monitors without uncentering it on normal desktop PCs.

The text should now always fit inside the status bar, either using three lines and smaller margins on small screens or using two lines and still centered on regular monitors.

BTW: The description gets shortened to 220 chars in any case.

Together with plnicks great additions providing streaming buttons, hover text and all those bells and whistles, I think this can be closed ...

ims21 commented 9 years ago

As I saw, this problem is on all 16:9 monitors when must be 3 lines. On all 4:3 monitors (on small resolution too) are 3 lines OK. On pictures you can see, when I changing width of Openwebif, how it is changing. There is not problem with a lot of text, but with some counting... webif_ok webif_wrong

Schimmelreiter commented 9 years ago

https://github.com/E2OpenPlugins/e2openplugin-OpenWebif/commit/18e98b397a2bbbfab58a7d691219d43d9afa5646

I've now pixel-exact determined the point for switching between 2 and 3 lines: 1534 and more pixels width: image

1533 and less pixels width: image