E2OpenPlugins / e2openplugin-OpenWebif

GPL Web Interface for e2stabs
GNU General Public License v3.0
205 stars 226 forks source link

Make distinction between channels in the channel list #832

Closed pr2git closed 6 years ago

pr2git commented 6 years ago

I have a channel list that mix up channels from: DVB-C, DVB-S(2) (from different satellite) (and IPTV) for exemple TF1.

I can receive it from my cable provider, 19.2E, 13.0E, 5.0W when I am in the channel list on my STB it is easy for me to make the distinction between each channels by enabling the icon in front of the name.

But on OpenWebif I just saw this:

capture d ecran 2018-08-05 a 00 31 40

Do you think possible to display an icon in front of the name to make a distinction between each different type?

pr2git commented 6 years ago

Here is what I saw in my STB channel list:

capture d ecran 2018-08-05 a 00 37 31
jbleyel commented 6 years ago

We can add an extra setting switch like "show picons" and this will add the orbital position at the end of the channel name. The orbital position can also be DVB-C,DVB-T or IPTV. Many users don't need this because they don't have different namspaces.

pr2git commented 6 years ago

It would be nicer to have it before the channel name because with a 5 digits approach you can cover them all: xxx.xE yyy.yW DVB-T DVB-C

So we have a nice alignment for this information.

But you can reuse the E2 settings, which is: Icon to the left of the service name: config.usage.servicetype_icon_mode=1 Icon on the right of the service name: config.usage.servicetype_icon_mode=2 No icon: config.usage.servicetype_icon_mode=0

This makes sense to reuse it since people that enable it, would probably like to see it too in OpenWebif.

jbleyel commented 6 years ago

We definitely do not use settings from the OSD GUI for the webinterface. Icon on right needs a complete redesign.

You can switch to the theme "original-small-screen".

pr2git commented 6 years ago

Thanks I just test your change but this mention DVB-S or DVB-C... but the orbital position is not displayed. So it is an improvement, thanks but I am still unable to make a distinction between the different satellites for the same channel name. For DVB-S I suggest that DVB-S test is replaced by the orbital position (which can be retrieve by the Namespace).

capture d ecran 2018-08-09 a 00 40 38

For me TV or HDTV is useless to display.

The test should be improved too to detect properly IPTV channel using #SERVICE 1:...

jbleyel commented 6 years ago

IPTV is 4097:xxx and not 1:xxx That's by definition and you have to change your bouquets. The orbital position will be displayed if your namespace is correct. You have to get the latest version.

pr2git commented 6 years ago

Enigma2 source code detect the IPTV channel by looking at "%3a//" or "%3A//" or "://" (since %3A is no longer mandatory) this is the proper way to check the service type for IPTV.

pr2git commented 6 years ago

Someone reusing the service reference of a DVB-S or DVB-C channel to assign it to the same channel in IPTV will saw wrong informations if you don't check properly for IPTV.

pr2git commented 6 years ago

The test to check if a SERVICE is a DVB-S is based on the Namespace, this is wrong because many people reuse the satellite reference of an existing channel to assign it to its IPTV equivalent. So for those people the IPTV link is reported has DVB-S with the orbital position. Exemple:

SERVICE 4097:0:19:2261:438:1:C00000:0:0:0:http://host:port/xxxx.ts:Canal+ HD

Will be reported to be on 19.2E (namespace C0) while it is IPTV.

jbleyel commented 6 years ago

No, you are wrong. Please check the code and test the latest source on your box first before you write something.

            #if '4097:' in $channel.ref
                <span class="channel-tag ST-IPTV">IPTV</span>
            #elif $channel.has_key('ns')
                #set $ns="DVB-S"
                #if 'DVB' in $channel.ns
                    #set $ns=$channel.ns
                #end if
                <span class="channel-tag ST-$channel.service_type">$channel.service_type</span><span class="channel-tag NS-$ns">$channel.ns</span>
            #end if
pr2git commented 6 years ago

Just test an indeed end-user report was wrong, sorry next time I will test myself. This only happens if end-user uses #SERVICE 1 for IPTV.

jbleyel commented 6 years ago

That's a different story. I will think about that.