search

E3SM-Project / ACME-ECP

E3SM MMF for DoE ECP project
Other
9 stars 1 forks source link

Fix build machine and compiler configuration files on summit with IBM compiler #112

Closed xyuan closed 4 years ago

xyuan commented 4 years ago

Adding a new module dependency (xalt/1.1.4) for the XL compiler. Without this change netcdf/pnetcdf modules fail to load with the XL compiler

[BFB]

xyuan commented 4 years ago

1): Adding a new module dependency (xalt/1.1.4) for the XL compiler. Without this change netcdf/pnetcdf modules fail to load with the XL compiler 2): Add option "-qrealsize=8" for double precision build.

These two changes fix the following build error with IBM xlf compiler.

"ERROR: module command /sw/summit/lmod/7.7.10/rhel7.3_gnu4.8.5/lmod/7.7.10/libexec/lmod python load DefApps python/3.5.2 subversion/1.9.3 git/2.13.0 cmake/3.11.3 essl netlib-lapack xl/16.1.1-1 netcdf netcdf-fortran spectrum-mpi parallel-netcdf hdf5 failed with message: Lmod has detected the following error: These module(s) exist but cannot be loaded as requested: "parallel-netcdf", "netcdf-fortran", "netcdf" Try: "module spider parallel-netcdf netcdf-fortran netcdf" to see how to load the module(s)."

brhillman commented 4 years ago

@xyuan does this just fix the non-MMF build? You will need to make more fixes, correct?

xyuan commented 4 years ago

@brhillman this modifications only make the code to be able to build, the source codes also need to fix some issues, such as type mismatch, and some fortran grammar error. I leave these to the developer.

whannah1 commented 4 years ago

@xyuan can you create a github issue to describe these type mismatch and grammar issues?

whannah1 commented 4 years ago

@xyuan I don't think the "enhancement" and "ECPP" labels apply to this PR. It seems to only be a fix to the machine config and not an additional feature and has nothing to do with aerosols. So you should remove those labels.

xyuan commented 4 years ago

@xyuan can you create a github issue to describe these type mismatch and grammar issues?

yes, will do it tomorrow.

jayeshkrishna commented 4 years ago

@xyuan : Can you modify the commit message (the commit that changed the code - requires rebase of your branch) or the PR description (which will be used as the commit message for the merge commit) to include more information on this change ?

(e.g. Adding a new module dependency (xalt/1.1.4) for the XL compiler. Without this change netcdf/pnetcdf modules fail to load with the XL compiler)

xyuan commented 4 years ago

close this PR to create a new PR without this auto-promotion option.