search

E3SM-Project / ACME-ECP

E3SM MMF for DoE ECP project
Other
9 stars 1 forks source link

Adding a new module dependency (xalt/1.1.4) for the XL compiler. Without this change netcdf/pnetcdf modules fail to load with the XL compiler #113

Closed xyuan closed 4 years ago

xyuan commented 4 years ago

Adding a new module dependency (xalt/1.1.4) for the XL compiler. Without this change netcdf/pnetcdf modules fail to load with the XL compiler

[BFB]

xyuan commented 4 years ago

I am closing this PR again, and create a new PR. sorry!

brhillman commented 4 years ago

@xyuan you do not have to open a new PR for changes, you can just make additional commits and push to this branch. And you can edit the PR description here as well. So unless this change is just unnecessary or otherwise invalid, or you want to push the changes upstream to E3SM, I wouldn't suggest closing in favor of opening another.

rljacob commented 4 years ago

The commit history is a little messy already. Its ok to start over to have a better commit history.