search

E3SM-Project / ACME-ECP

E3SM MMF for DoE ECP project
Other
9 stars 1 forks source link

Update RRTMGP submodule #124

Closed brhillman closed 4 years ago

brhillman commented 4 years ago

Update RRTMGP submodule to most recent commit on branch "develop" on external repository. This includes a lot of changes for OpenACC, which is a prerequisite for us being able to build RRTMGP and the RRTMGP interface within E3SM-MMF for the GPU on Summit. This also includes API changes for the gas concentrations interface, so changes are present in radiation.F90 to deal with this. This will cause BFB differences for the cam-rrtmgp test. These differences are due to only two changes:

1) Commit de24173cc97ec2e2d7eb30810ef205789c27e2bb in the external repo refactors the get_col_dry routine to put the calculations on the GPU via OpenACC. This requires splitting a computation into two parts, and this causes floating point differences that will produce a DIFF.

2) The absorption coefficient data is updated to the most recent version available from the remote repository. This also causes small differences.

Manually reverting both of these brings the test back to BFB, so we can be sure that the diff is resulting from these trivial changes and is acceptable. All other tests should be BFB. This PR parallels PR 3375 on E3SM master.

brhillman commented 4 years ago

@crjones-amath this should be ready to go now.