search

E3SM-Project / ACME-ECP

E3SM MMF for DoE ECP project
Other
9 stars 1 forks source link

ECPP - use of ntavg1_ss and ntavg2_ss is unclear, and ECPP #61

Closed whannah1 closed 6 years ago

whannah1 commented 6 years ago

The ECPP variables ntavg1_ss and ntavg2_ss are specified down in crm_module.F90. These should be specified somewhere else, like an ecpp_parameters.F90 file, and the way these variables are used should be clearly described in a comment. Currently, the effect of changing these variables is unclear.

ntavg1_ss = min(600._r8, dt_gl)   ! 10 minutes  or the GCM timestep, whichever smaller
ntavg2_ss = dt_gl                 ! # of seconds to average between computing categories, must be a multiple of ntavgt1_ss.

related to issue #47

crjones-amath commented 6 years ago

PR #67 fixed issue #47 and partially clarified these differences. Is that sufficient to close this issue, or should it remain open?

whannah1 commented 6 years ago

I think the fix in PR#67 is enough to close this.