search

E3SM-Project / ChemDyg

Chemistry Diagnostics Package
BSD 3-Clause "New" or "Revised" License
0 stars 2 forks source link

Change eam input, section name, and observational/reference data paths #6

Closed hsiangheleellnl closed 1 year ago

hsiangheleellnl commented 1 year ago

There are some changes regarding eam file reading and the section name change from e3sm_chem_diags to chemdyg.

xylar commented 1 year ago

@hsiangheleellnl, it seems like you'll need to rebase this branch onto origin/main to pick up the files getting moved in #1. Other than that, I'm not sure I can provide much useful feedback on the code changes themselves.

hsiangheleellnl commented 1 year ago

rebase the changes onto 'origin/main'

xylar commented 1 year ago

@hsiangheleellnl, there's no need to close the PR. You can just rebase onto origin/master and then force-push the branch to the remote branch. Then, the PR will be updated automatically.

xylar commented 1 year ago

@hsiangheleellnl, let me know if more detailed instructions would be helpful. I'm happy to provide them.

tangq commented 1 year ago

@xylar , I showed Hsiang-He how to rebase and the conflicts should be resolved now.

The commit (832b549) changes to use relative paths for input files as suggested in https://github.com/E3SM-Project/ChemDyg/issues/4#issuecomment-1470790434.

The reference_data_path is set in ChemDyg_example_script.cfg and should match the root input data path, which mache should know for each machine. Do you have suggestions on how to set the root path automatically for different machines?

xylar commented 1 year ago

@tangq, thank you for clarifying what you need from me here. I can add an example of how to use mache to find the path on each machine in one of your bash scripts and you can hopefully figure out how to make similar changes to other scripts.

xylar commented 1 year ago

@hsiangheleellnl and @tangq, I pushed a commit that I think will take care of this. I think that zppy will provide the diagnostics_base_path config option (which it will get from mache) if I understand https://github.com/E3SM-Project/zppy/pull/402 correctly.

tangq commented 1 year ago

@xylar , thank you. The diagnostics_base_path config option is exactly what I am looking for.