search

E3SM-Project / E3SM

Energy Exascale Earth System Model source code. NOTE: use "maint" branches for your work. Head of master is not validated.
https://docs.e3sm.org/E3SM
Other
351 stars 360 forks source link

line too long in mpas_li_thermal.F #2296

Closed minxu74 closed 6 years ago

minxu74 commented 6 years ago

PGI compiler on Titan reported an error of "line too long" during compiling maps_li_thermal.F. The trace stack pointed to a comment line at Line 3060.

! Seroussi, H., Y. Nakayama, E. Larour, D. Menemenlis, M. Morlighem, E. Rignot, and A. Khazendar (2017), Continued retreat of Thwaites Glacier, West Antarctica, controlled by bed topography and ocean circulation, Geophys. Res. Lett., 1-9, doi:10.1002/2017GL072910.

minxu74 commented 6 years ago

@matthewhoffman Could you fix the problem and let the length of the comment line be less than 132? I have done tests and confirmed that the change will fix the fails of three MPASLI related tests in E3SM developer test suite. Thanks.

matthewhoffman commented 6 years ago

@minxu74 , I started working on this and found many more instances that also need to be cleaned up. I won't get to finish it today.

rljacob commented 6 years ago

Don't close this until the fix is merged to master.

minxu74 commented 6 years ago

@matthewhoffman @rljacob The fixtures to this issue seemed to be reverted some how. It caused all three test failures on Titan. They are SMS.f09_g16_a.IGCLM45_MLI.titan_pgi, ERS.f09_g16_g.MALISIA.titan_pgi, and SMS.T62_oQU120_ais20.MPAS_LISIO_TEST.titan_pgi.

rljacob commented 6 years ago

The exact same line is now to long again?

minxu74 commented 6 years ago

Yes. Exactly.

jonbob commented 6 years ago

I checked and it looks like all the changes we made recently to mpas-albany-landice were lost in an mpas-ocean update to the mpas-source submodule. We'll track it down and get it fixed as soon as possible.