search

E3SM-Project / E3SM

Energy Exascale Earth System Model source code. NOTE: use "maint" branches for your work. Head of master is not validated.
https://docs.e3sm.org/E3SM
Other
346 stars 353 forks source link

build error in CAM4 (if anyone cares) #287

Closed worleyph closed 8 years ago

worleyph commented 9 years ago

@bmayerornl discovered a build error in an F1850 case, in the subroutine radiation_init, in ./atm/cam/src/physics/cam/radiation.F90 . The variable 'dtime' and the routine 'get_step_size' are not declared in this routine. Should be a simple fix, but I am surprised that this was not noticed before, and am wondering if it was introduced recently?

jeff-cohere commented 9 years ago

My understanding is that we are not shipping CAM4 with ACME, so this isn't all that surprising.

worleyph commented 9 years ago

But I assume that it did not use to be broken - we started out running with CAM4. Seems strange that someone would change code that we no longer care about, and break it in the process.

bishtgautam commented 9 years ago

Using the blame feature, I believe 2dd78045f0eb26cd206495a913c70c3992707de9 introduced the bug.

bmayerornl commented 9 years ago

With Pat's suggested changes the build gets past 'atm'. The rest of the build is still running.

From: worleyph notifications@github.com<mailto:notifications@github.com> Reply-To: ACME-Climate/ACME reply@reply.github.com<mailto:reply@reply.github.com> Date: Thursday, July 30, 2015 at 1:38 PM To: ACME-Climate/ACME ACME@noreply.github.com<mailto:ACME@noreply.github.com> Cc: Benjamin Mayer mayerbw@ornl.gov<mailto:mayerbw@ornl.gov> Subject: [ACME] build error in CAM4 (if anyone cares) (#287)

@bmayerornlhttps://github.com/bmayerornl discovered a build error in an F1850 case, in the subroutine radiation_init, in ./atm/cam/src/physics/cam/radiation.F90 . The variable 'dtime' and the routine 'get_step_size' are not declared in this routine. Should be a simple fix, but I am surprised that this was not noticed before, and am wondering if it was introduced recently?

Reply to this email directly or view it on GitHubhttps://github.com/ACME-Climate/ACME/issues/287.

singhbalwinder commented 9 years ago

The radiation_driver.F90 used for CAM4 is in physics/cam/radiation.F90 (which has this bug). CAM5 uses physics/rrtmg/radiation_driver.F90, which includes the needed "use" statement.

While working on another bug fix, I tried to match up both the radiation_driver.F90 files but I didn't test the model with a CAM4 simulation. I will fix this issue.

douglasjacobsen commented 9 years ago

In case you want the historical information, it looks like this was introduced in commit 2dd7804.