search

E3SM-Project / E3SM

Energy Exascale Earth System Model source code. NOTE: use "maint" branches for your work. Head of master is not validated.
https://docs.e3sm.org/E3SM
Other
347 stars 354 forks source link

pressure update due to phase change #4693

Open mt5555 opened 2 years ago

mt5555 commented 2 years ago

At the end of the physics timestep the pressure has to be updated due to sources/sinks of water vapor. in E3SM v1 and v2, this change is made in the surface pressure and then distributed uniformly through the column. In a vertically lagrangian model, the correct behavior is to change the pressure locally, based on the local changs in water vapor.

This is a small change with minor climate impacts, but implementation is on hold so as to not change v2 behavior.

oksanaguba commented 2 years ago

Climo etc. runs for the new option vs the old option https://acme-climate.atlassian.net/wiki/spaces/COM/pages/1632864081/Climo+6-year+runs+for+ps+adjustment+dp3d+adjustment+T+adjustment+choices .

rljacob commented 2 years ago

@kvcalvin @susburrows @jenniferholm see if you want this fixed for v2 BGC.

jenniferholm commented 2 years ago

@rljacob - As far as I can tell, I don't think we need this surface pressure fix for v2 BGC. Thanks

susburrows commented 2 years ago

This will be a nice improvement in physical consistency, but I agree we don't need it for v2 BGC.

mt5555 commented 2 years ago

I agree that this is a low priority. I propose we put this on hold until we have the new climate changing feature review policy being developed under the code review deepdive.