search

E3SM-Project / E3SM

Energy Exascale Earth System Model source code. NOTE: use "maint" branches for your work. Head of master is not validated.
https://docs.e3sm.org/E3SM
Other
336 stars 339 forks source link

Fixes for multiple issues in gustiness calculations. #5850

Closed quantheory closed 7 months ago

quantheory commented 10 months ago

This is designed to fix the following issues:

The first of these was fixed by forcing ATM_SUPPLIES_GUSTINESS=TRUE for all EAM cases, and the second was fixed purely by rewriting the Fortran formulas. These two changes are climate changing, and will generally tend to reduce the impact of gustiness on the mean winds, i.e. mean wind speed will increase.

The third fix is to the U10 diagnostic only, and will decrease the output U10. A value that has not been "fixed" in this way can be obtained by outputting the new history variable 'U10WITHGUSTS' from EAM.

The final fix is to remove some double-counting between gustiness parameterizations in EAM and ELM. The fix can be "undone" by setting force_land_gustiness = .true. in the ELM namelist.

Note that these fixes are only applied over land and ocean. At the request of sea ice developers, this tag also disables gustiness over sea ice completely.

Fixes #5834 Fixes #5835 Fixes #5836 Fixes #5837

[CC] [NML]

crterai commented 7 months ago

@vanroekel - After Sean Santos identified a fix for our earlier crash (issue came from a bug unrelated to this PR: https://github.com/E3SM-Project/E3SM/pull/6034), I've been able to push the simulation further than our earlier simulation and we now have 90+years. I've created the MPAS diagnostics IICE for the 100 year comparison: IICE. Would you take a look at the OHC anomalies to see if they look reasonable?

vanroekel commented 7 months ago

Thanks for the updated diags @crterai I've looked through them and a couple things

  1. could you possibly resubmit the diags with the climatologies from 51-100 (or whatever your last year is) instead of including all the record? The comparison is not consistent with v3alpha4 right now
  2. Looking through the time series there is definitely more OHC uptake with this PR, it's not largely different, but definitely stronger
  3. the SSH appears to be increasing through the length of the run image

Does this make sense? v3alpha4 seems to be stabilizing but not this run

XubinZeng commented 7 months ago

Thanks Chris @crteraihttps://github.com/crterai !

agree with Luke:

while not analyzing the ENSO carefully, from the power spectrum, the new run seems to increase the power spectrum density from 3-6 years - probably representing a small improvement over the control - a positive news.

From: Luke Van Roekel @.> Sent: Wednesday, November 15, 2023 12:47 PM To: E3SM-Project/E3SM @.> Cc: Zeng, Xubin - (xubin) @.>; Mention @.> Subject: [EXT]Re: [E3SM-Project/E3SM] Fixes for multiple issues in gustiness calculations. (PR #5850)

External Email

Thanks for the updated diags @crteraihttps://github.com/crterai I've looked through them and a couple things

  1. could you possibly resubmit the diags with the climatologies from 51-100 (or whatever your last year is) instead of including all the record? The comparison is not consistent with v3alpha4 right now
  2. Looking through the time series there is definitely more OHC uptake with this PR, it's not largely different, but definitely stronger
  3. the SSH appears to be increasing through the length of the run [image]https://user-images.githubusercontent.com/13662545/283230351-82219789-b665-4e7c-aa4e-b6bef2fb095d.png

Does this make sense? v3alpha4 seems to be stabilizing but not this run

— Reply to this email directly, view it on GitHubhttps://github.com/E3SM-Project/E3SM/pull/5850#issuecomment-1813162450, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AP2S7YUZB2PAAJ7ZWB66SNLYEUL4RAVCNFSM6AAAAAA2674VUWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJTGE3DENBVGA. You are receiving this because you were mentioned.Message ID: @.***>

crterai commented 7 months ago

Thanks for looking at the diagnostics, @vanroekel.

The last 6 year chunk is still in the queue, so here's the MPAS diagnostics where the climo fields are averaged over 0051-0090: IICE.

Regarding the SSH, I don't see any reason why SSH should be different with the gustiness fix. However, I did take a look at the SSH trend in the baseline trigrid v3alpha04 simulation, which was continued out to year 300, and while we see it flatten from year 81-100, it does continue to go up after year 100 through the end of the simulation. So it looks like the increasing SSH is just a feature of our baseline, and not specific to the gustiness bug fixes. From MPAS-Analysis. image

And yes, @XubinZeng, the ENSO power spectrum is one potential improvement that comes from these simulations.

vanroekel commented 7 months ago

Thanks for the new diags @crterai I took a look through and things seem pretty close to the baseline. Thanks for that SSH figure as well. I'll go ahead an approve this now.

wlin7 commented 7 months ago

Merged to next.

rljacob commented 7 months ago

removed from next with a force push. Wait until tomorrow.

wlin7 commented 7 months ago

Re-merged to next.

wlin7 commented 7 months ago

Merged to master. Thanks @quantheory for the great work, and careful reviews by all the reviewers.

Special notes on some diffs following this PR: