Jgfouca/scream downstream 04 11 24

jgfouca commented 1 month ago

Bring latest EAMxx and other changes from scream repo.

Non-eamxx changes: 1) Change GitHub CI to skip E3SM CI for eamxx (for now) 2) Add an eamxx-specific workflow in the CI to ensure default input files for SCREAM are available and downloadable 3) ELM config changes: new namelist defaults added for ne256pg2 and ne1024pg2 land configurations to support F20TR compsets with these resolutions 4) EAM changes: scream/micro_p3.F90 updates/fixes. Should only impact SCREAM stuff. Also, there's a fix for DP SCREAM output coordinate issue where x-coordinates should be assocated with spherep lon values and y-coordinates should be associated with lat values 5) Change kokkos build to ensure cxx17 standard

[non-BFB] for HOMMExx cases.

On mappy, this PR is non-BFB for these cases, which I think is expected:

DIFF ERS_D.ne4pg2_oQU480.F2010.mappy_gnu.eam-hommexx (phase BASELINE)
DIFF SMS_Ln9_P24x1.ne4_ne4.FDPSCREAM-ARM97.mappy_gnu (phase BASELINE)
DIFF SMS_R_Ld5.ne4_ne4.FSCM-ARM97.mappy_gnu.eam-scm (phase BASELINE)

github-actions[bot] commented 1 month ago

PR Preview Action v1.4.7 :---: :rocket: Deployed preview to https://E3SM-Project.github.io/E3SM/pr-preview/pr-6343/ on branch gh-pages at 2024-04-11 15:56 UTC

rljacob commented 1 month ago

PR description is better but still needs some words about the changes to eam code.

jgfouca commented 4 weeks ago

@rljacob , done.

rljacob commented 4 weeks ago

Also, can you describe what cases this in non-BFB for?

rljacob commented 4 weeks ago

Oh I see you did. Nevermind.

jgfouca commented 4 weeks ago

Merged to next.

rljacob commented 3 weeks ago

@jgfouca this caused some diffs in integration tests that use SCREAM. Please make bless requests.

jgfouca commented 3 weeks ago

@rljacob , done

E3SM-Project / E3SM

Jgfouca/scream downstream 04 11 24 #6343