search

E3SM-Project / E3SM

Energy Exascale Earth System Model source code. NOTE: use "maint" branches for your work. Head of master is not validated.
https://docs.e3sm.org/E3SM
Other
332 stars 334 forks source link

Fix logical on flds_polar driver namelist #6351

Closed darincomeau closed 4 weeks ago

darincomeau commented 1 month ago

In https://github.com/E3SM-Project/E3SM/pull/6229, the logic on the new driver namelist option flds_polar was not set to true in G-cases where data icebergs were not active, but ice-shelf melt fluxes were. This caused the model to crash on ocn init in ocn_comp_mct.F. This expands the logic for defining that namelist option to TRUE to include these cases.

[BFB]

Fixes https://github.com/E3SM-Project/E3SM/issues/6349

darincomeau commented 1 month ago

With this the following tests that were failing with https://github.com/E3SM-Project/E3SM/pull/6229 now pass

darincomeau commented 1 month ago

Also passes

Pending

darincomeau commented 4 weeks ago

Passed

jonbob commented 4 weeks ago

Verified that it fixes the test that had previously been failing. Also passes sanity testing.

merged to next

jonbob commented 4 weeks ago

merged to master and blessed tests that this PR fixed -- thanks @darincomeau