Adds new I-Compsets that are consistent with WCv3

E3SM-Project / E3SM

Energy Exascale Earth System Model source code. NOTE: use "maint" branches for your work. Head of master is not validated.

https://docs.e3sm.org/E3SM

Other

332 stars 334 forks source link

Adds new I-Compsets that are consistent with WCv3 #6362

Closed bishtgautam closed 1 week ago

bishtgautam commented 3 weeks ago

Adds I-compsets that include active BGC (CNP+RD+CTC), black carbon (BC), and subgrid topographic parameterization for solar radiation (TOP) in ELM.
These I-Compsets use GSWP DATM forcing.
The compsets are for 1850, 20TR, and 2000. [BFB]

github-actions[bot] commented 3 weeks ago

PR Preview Action v1.4.7 :---: :rocket: Deployed preview to https://E3SM-Project.github.io/E3SM/pr-preview/pr-6362/ on branch gh-pages at 2024-04-23 17:42 UTC

rljacob commented 2 weeks ago

Do these need to be in a test suite also or is it enough that they are tested in fully coupled cases?

rljacob commented 1 week ago

@acme-y9s please review this.

bishtgautam commented 1 week ago

To get this merged to the master on Monday, we can skip adding new tests as that would require nightly tests to be run. Later on, we can replace a few existing tests with tests using these new compsets. Till the time being, we can rely on the existing fully coupled tests.

peterdschwartz commented 1 week ago

@rljacob should I go ahead a merge to next

rljacob commented 1 week ago

Yes go ahead.

peterdschwartz commented 1 week ago

merged to master