E3SM-Project / E3SM

Energy Exascale Earth System Model source code. NOTE: use "maint" branches for your work. Head of master is not validated.
https://docs.e3sm.org/E3SM
Other
332 stars 334 forks source link

Removes few ELM fields that were added by default #6366

Open bishtgautam opened 3 weeks ago

bishtgautam commented 3 weeks ago

The glacier-related fields should only be added when create_glacier_mec_landunit = .true..

Fixes #6365

bishtgautam commented 3 weeks ago

@golaz Could you please try this branch to see if it fixes the error reported in #6365?

bishtgautam commented 3 weeks ago

@rljacob While the answers will not change, the tests using this branch will report that the ELM restart file is missing a few fields. Should this PR be marked as BFB or non-BFB?

rljacob commented 3 weeks ago

restart files are not compared in testing. just history.

bishtgautam commented 3 weeks ago

I have updated the label and comment.

rljacob commented 2 weeks ago

@golaz please try this out.

peterdschwartz commented 12 hours ago

since @rljacob went ahead and approved, that I'll go ahead with the merge today unless there are any objections.

peterdschwartz commented 8 hours ago

Merged to next. Expect DIFFs due to FIELD LIST for any tests that compare elm.h0 files.