move semoab_mod file to homme shared folder

E3SM-Project / E3SM

Energy Exascale Earth System Model source code. NOTE: use "maint" branches for your work. Head of master is not validated.

https://docs.e3sm.org/E3SM

Other

332 stars 334 forks source link

move semoab_mod file to homme shared folder #6369

Closed iulian787 closed 1 week ago

iulian787 commented 3 weeks ago

semoab_mod.F90 file is moved from components/eam/src/dynamics/se folder to components/homme/src/share folder.

It belongs naturally there, as it involves just grid routines from homme base code

also, it should prepare for SCREAM-moab connection later on

fix also some complaints about non-allocated arrays when there are no cells on some dynamic tasks (when number of tasks is larger than number of spectral cells in homme)

[BFB]

github-actions[bot] commented 3 weeks ago

PR Preview Action v1.4.7 :---: :rocket: Deployed preview to https://E3SM-Project.github.io/E3SM/pr-preview/pr-6369/ on branch gh-pages at 2024-04-25 21:43 UTC

oksanaguba commented 1 week ago

not sure what to review here -- i do not think standalone homme would pick this file in its builds, also, it is probably not possible to incorporate moab functionality into standalone homme.

rljacob commented 1 week ago

I just wanted someone responsible for the HOMME code to approve moving the file there. Thanks!