search

E3SM-Project / E3SM

Energy Exascale Earth System Model source code. NOTE: use "maint" branches for your work. Head of master is not validated.
https://docs.e3sm.org/E3SM
Other
332 stars 334 forks source link

Update global ocean init mode for meshes with ice-shelf cavities #6375

Open xylar opened 2 weeks ago

xylar commented 2 weeks ago

This merge updates MPAS-Ocean init mode for global_ocean in several ways that are critical for initialization that is compatible with planned coupling to MALI.

The fields landIcePressure, landIceDraft and ssh are now read from a topography file. This means that landIcePressure is no longer computed based on the density at the ocean surface in init mode. Similarly, ssh is not required to be the same as landIceDraft.

Support is removed for reading land-ice topography fields from a dataset on a lat-lon grid. We no longer use this capability and maintaining it is not worth the effort.

The land-ice topography data set is now required to have landIceFloatingFracObserved as a field, and this is used to set landIceFloatingFraction. Previously, landIceFracObserved was being used to compute both landIceFraction and landIceFloatingFraction (assuming no grounded ice in the domain).

xylar commented 2 weeks ago

This has been moved from https://github.com/E3SM-Ocean-Discussion/E3SM/pull/90, which includes relevant discussion.

xylar commented 2 weeks ago

@mark-petersen, you are the best person I could think of to sanity check changes to init mode. Let me know if you can do that.

xylar commented 2 weeks ago

@mark-petersen, this is a high priority for the FAnSSIE project. Can you review when you can?

xylar commented 2 weeks ago

Sorry, I forgot I already pinged you...

xylar commented 2 days ago

@sbrus89, @mark-petersen is away and I need someone to review this that knows about MPAS-Ocean's global ocean init mode. You're the best candidate. Would you be up for reviewing this? If not, remove yourself as a reviewer and I'll find someone else.

sbrus89 commented 1 day ago

@xylar, sure I will take a look.