Changing datestamp on JRA v1.5 runoff files to corrected versions (maint-2.1)

E3SM-Project / E3SM

Energy Exascale Earth System Model source code. NOTE: use "maint" branches for your work. Head of master is not validated.

https://docs.e3sm.org/E3SM

Other

332 stars 334 forks source link

Changing datestamp on JRA v1.5 runoff files to corrected versions (maint-2.1) #6383

Closed darincomeau closed 2 weeks ago

darincomeau commented 2 weeks ago

This changes the datestamp on the JRA v1.5 runoff files to corrected versions that have fixed negative liquid runoff values around Greenland and Antarctica. These files have been staged in the public inputdata directory as world readable.

[non-BFB] for compsets with JRAv1.5 forcing

Fixes https://github.com/E3SM-Project/E3SM/issues/6378.

darincomeau commented 2 weeks ago

Confirmed new runoff files have minimum rofl = 0.

Passes

SMS.TL319_EC30to60E2r2.GMPAS-JRA1p5.chrysalis_intel
SMS.TL319_ECwISC30to60E2r1.GMPAS-JRA1p5-DIB-ISMF.chrysalis_intel
SMS.TL319_EC30to60E2r2.DMPAS-JRA1p5.chrysalis_intel

and confirmed the 240411 datestamp runoff files are being used.

darincomeau commented 2 weeks ago

Already reviewed in the PR into master https://github.com/E3SM-Project/E3SM/pull/6379, @jonbob can I just add you as reviewer here or would you like me to ping someone else?

jonbob commented 2 weeks ago

Thanks @darincomeau -- I think it's fine for me to review, since the equivalent PR into master went through several other people

jonbob commented 2 weeks ago

merged to maint-2.1