E3SM-Project / E3SM

Energy Exascale Earth System Model source code. NOTE: use "maint" branches for your work. Head of master is not validated.
https://docs.e3sm.org/E3SM
Other
332 stars 334 forks source link

Solve gas_ac=NAN issue #6385

Closed hsiangheleellnl closed 2 weeks ago

hsiangheleellnl commented 2 weeks ago

Skip gas_ac calculation when nstep = 0. Otherwise a run in debug mode would fail.

Fixes #6304.

[BFB]

tangq commented 2 weeks ago

@hsiangheleellnl , does this PR fix https://github.com/E3SM-Project/E3SM/issues/6304?

hsiangheleellnl commented 2 weeks ago

@tangq Thank you for clarifying that. The changes of this pull request fixed the issue #6304.

github-actions[bot] commented 2 weeks ago

PR Preview Action v1.4.7 :---: :rocket: Deployed preview to https://E3SM-Project.github.io/E3SM/pr-preview/pr-6385/ on branch gh-pages at 2024-05-01 22:41 UTC

wlin7 commented 2 weeks ago

@hsiangheleellnl @tangq , thanks for the fix. The updated SSP test (via #6335) in debug mode (SMS_D_Ld1.ne30pg2_r05_IcoswISC30E3r5.WCYCLSSP370) also failed without this fix.

wlin7 commented 2 weeks ago

Merged to next.