Porting ACME to PIO2 - Githubissues

E3SM-Project / E3SM

Energy Exascale Earth System Model source code. NOTE: use "maint" branches for your work. Head of master is not validated.

https://docs.e3sm.org/E3SM

Other

344 stars 351 forks source link

Porting ACME to PIO2 #659

Closed jayeshkrishna closed 8 years ago

jayeshkrishna commented 8 years ago

ACME currently supports PIO1. PIO2 has introduced some changes to the existing interfaces and the code (components) in ACME needs to be modified to support the PIO2 interface.

PIO_OFFSET is replaced by PIO_OFFSET_KIND
pio_setframe() now takes a file_desc_t as an additional (first) parameter and the frame is now of type PIO_OFFSET_KIND
pio_subsystem is an opaque data structure now. i.e., The internals of the structure (io_rank etc) is no longer accessible. The corresponding function accessors should be used (pio_iotask_rank() instead of io_subsystem%io_rank).
pio_inq_att() now takes a attribute length of type PIO_OFFSET_KIND instead of PIO_OFFSET

PIO1 included in ACME provides support for both PIO1 and PIO2 interfaces. Some changes required for PIO2 supported was also added in 7a3eefd5d5d5edb1acad7f304da1921fd4243ead

jayeshkrishna commented 8 years ago

CAM, HOMME, CLM, CICE, RTM, MOSART will be modified to support PIO2 interfaces.
MPAS-* will be modified separately by the MPAS developers
The build system will also be modified separately (ESMCI) to support PIO2 (optionally switch btw PIO1 and PIO2 at build time)

jayeshkrishna commented 8 years ago

ACME now builds locally (not checked in) with PIO1 and PIO2. However the model runs fails with PIO2. I will try to get ACME changes for PIO2 tested with PIO1 and check them in. Then will work on getting ACME working with PIO2.

mt5555 commented 8 years ago

@jayeshkrishna : just a warning: ACME regression tests run HOMME standalone tests, and the HOMME standalone driver is also making PIO calls. So that code will have to be upgraded as well.

jayeshkrishna commented 8 years ago

Thanks for the heads up @mt5555 . I will try the regression tests too then.

jayeshkrishna commented 8 years ago

Verified that the HOMME regression tests work after merging (locally) the branch to next on Cetus

jayeshkrishna commented 8 years ago

The Integration tests (with comparison) work on blues+intel after merging (locally) the branch to next

jayeshkrishna commented 8 years ago

Waiting for SMS.ne30_oEC.A_WCYCL2000 to work on Cetus or Edison (tried on blues but this test fails during initialization - possibly a memory issue) before merging to next

jayeshkrishna commented 8 years ago

Verified that a 2-day run of SMS.ne30_oEC.A_WCYCL2000 runs successfully on Edison (intel) after merging locally to next.