search

E3SM-Project / E3SM

Energy Exascale Earth System Model source code. NOTE: use "maint" branches for your work. Head of master is not validated.
https://docs.e3sm.org/E3SM
Other
353 stars 362 forks source link

elm: heterotrophic respiration diagnostic out of order? #6721

Open rgknox opened 1 week ago

rgknox commented 1 week ago

Total heterotrophic respiration is the combination of respiration from litter and soil. This diagnostic "hr" is updated in ColumnDataType.F90:col_cf_summary(), here:

https://github.com/E3SM-Project/E3SM/blob/master/components/elm/src/data_types/ColumnDataType.F90#L7264-L7266

However, we see that its components lithr and somhr are updated later in this same call sequence. Here:

https://github.com/E3SM-Project/E3SM/blob/master/components/elm/src/data_types/ColumnDataType.F90#L7310 https://github.com/E3SM-Project/E3SM/blob/master/components/elm/src/data_types/ColumnDataType.F90#L7322

Does anyone know if this is the intent? I would have expected the litter and som components to be built before being used to fill hr. It seems like HR is out of phase (ie lagging at best, or uninitialized at worst..).

@thorntonpe @bishtgautam

thorntonpe commented 1 week ago

@rgknox this looks like a bug to me - good catch! I think it would produce either a zero or uninitialized on first time step, and afterwards might be lagged by a time step. We are currently running diagnostics on recent V3 LR coupled simulations, and these variables should be in the output list. I will check them and report back here.