search

E3SM-Project / E3SM

Energy Exascale Earth System Model source code. NOTE: use "maint" branches for your work. Head of master is not validated.
https://docs.e3sm.org/E3SM
Other
353 stars 365 forks source link

Update gw_convect #6749

Closed whannah1 closed 2 days ago

whannah1 commented 1 week ago

The PR makes several changes to the convective gravity wave methods. The primary motivation was to address a problem in gw_beres_src() where the diagnosed heating max/depth values were erroneously too low whenever the ZM heating profile included negative values (or zero) in the middle of the heating layer. Additionally, previously hard coded values were exposed as namelist values for a planned QBO tuning exercise for the QBO SciDAC project.

[BFB] [NML] new nml variables for eam tests with default physics.

github-actions[bot] commented 1 week ago

PR Preview Action v1.4.8 :---: :rocket: Deployed preview to https://E3SM-Project.github.io/E3SM/pr-preview/pr-6749/ on branch gh-pages at 2024-11-18 15:49 UTC

whannah1 commented 4 days ago

e3sm_atm_developer passes on Chrysalis, but it didn't do the baseline comparison (my mistake). I ran a single "SMS.ne4pg2_oQU480.F2010.chrysalis_intel.eam-cosplite" test with baseline comparison enabled and it passes - so my expectation of these changes being BFB holds up.

wlin7 commented 3 days ago

Merged to next.