E3SM-Project / E3SM

Energy Exascale Earth System Model source code. NOTE: use "maint" branches for your work. Head of master is not validated.
https://docs.e3sm.org/E3SM
Other
353 stars 365 forks source link

EAMxx: Modify microphysics interface to include sethet (washout rates) #6752

Closed odiazib closed 2 days ago

odiazib commented 5 days ago

An existing EAMxx interface (eamxx_mam_microphysics_process_interface.cpp) is modified to include the invocation of the washout rates for gases.

Since the CMake option, SCREAM_ENABLE_MAM, is always ON, these codes are always compiled with the EAMxx codebase, but this interface can be turned off/on using the namelist flags.


Output variables

This process computes het_rates that are used in gas phase chemistry

Testing

We have existing tests for this interface, so we didn't add any new tests. We have a suite of validation tests in the MAM4xx repo to validate sethet process

The atmchange command to invoke this process in a CIME simulation is:

./atmchange physics::atm_procs_list="mac_aero_mic,rrtmgp,mam4_aero_microphys

To set up a test with the above configuration, use the following commands:

cd cime/scripts
./create_test SMS_D_P32x1_Ln5.ne4pg2_oQU480.F2010-SCREAMv1-MPASSI.<machine>_<compiler>.scream-mam4xx-aero_microphysics -t <test id> -p <project id>

Where,

is the machine name is the compiler to use on the machine is a unique string test identifier is the allocation project to charge `scream-mam4xx-aero_microphysics` is the test modifier that adds `mam4_aero_microphys` to the `atm_procs_list` process list and increases the number of tracers to 41. For `ne30pg2` grid, use the following command: ``` ./create_test SMS_D_P32x1.ne30pg2_oECv.F2010-SCREAMv1-MPASSI._.scream-mam4xx-aero_microphysics -t -p ``` ### New input data No new input data ## Figures from model analysis (Coming soon) ### Standalone Test Timings (Compy): We will upload the timings once the PR is reviewed and approved
singhbalwinder commented 4 days ago

Tagging @susburrows

rljacob commented 4 days ago

@bartgol looks like the eamxx testing is working here.

odiazib commented 4 days ago

@bartgol looks like the eamxx testing is working here.

But the tests are not running... They are still pending.

rljacob commented 4 days ago

Sorry by "working" I meant the github action is recognizing the eamxx changes and launching the jobs.

bartgol commented 4 days ago

Sorry by "working" I meant the github action is recognizing the eamxx changes and launching the jobs.

Yes, our runners are configured to only listen to e3sm-project/scream on github. I will try to switch them to e3sm-project/e3sm and see what happens there. I don't think they allow us to share the same runner across projects, even though I think gh allows to have org-level runners