Methane production is zero

E3SM-Project / E3SM

Energy Exascale Earth System Model source code. NOTE: use "maint" branches for your work. Head of master is not validated.

https://docs.e3sm.org/E3SM

Other

346 stars 353 forks source link

Methane production is zero #720

Closed bishtgautam closed 8 years ago

bishtgautam commented 8 years ago

The refactor of call sequence in clm4_5_13 resulted in CH4PROD = 0.

Recap of the changes made to the subroutines in clm4_5_13

Hydrology2() = Hydrology2NoDrainage()     + Hydrology2Drainage()
CNEcosystemDyn() = CNEcosystemDynNoLeaching() + CNEcosystemDynLeaching()

clm4_5_12 call seq.

call Hydrology2()
call CNEcosystemDyn()
call ch4()

clm4_5_13 call seq.

call Hydrology2NoDrainage()
call CNEcosystemDynNoLeaching()
call ch4()
call Hydrology2Drainage()
call CNEcosystemDynLeaching()

CSEG identified this bug as bug-2225 and bug-2287 and fixed it in clm4_5_8_r168

jinyuntang commented 8 years ago

@bishtgautam, I believe now the bug is fixed through the introduction of a subroutine hr_summary_for_ch4 to calculate somhr and lithr in CNCarbonfluxType.F90 for ch4 production in the ch4mod.F90. a 10 months run indicate methane production flux is no longer zero. The branch is jinyuntang/lnd/ch4_zero_bugfix. This bug fix will not be bfb for simulations with active ch4 cycle.

bishtgautam commented 8 years ago

@jinyuntang : Can you issue a PR?

jinyuntang commented 8 years ago

sure

On Mon, Feb 22, 2016 at 2:25 PM, Gautam Bisht notifications@github.com wrote:

@jinyuntang https://github.com/jinyuntang : Can you issue a PR?

— Reply to this email directly or view it on GitHub https://github.com/ACME-Climate/ACME/issues/720#issuecomment-187416472.

Jinyun

Jinyun Tang, Research Scientist Lawrence Berkeley National Laboratory 1 Cyclotron Rd., MS 74R316C Berkeley, CA 94720 tel: 510 486-5792, fax: 510 486-7070