search

E3SM-Project / HOMMEXX

Clone of ACME for CMDV-SE project to convert HOMME to C++
11 stars 0 forks source link

updating logic about diagnostics in prim_driver to match homme #281

Closed oksanaguba closed 6 years ago

oksanaguba commented 6 years ago

Updating some logic around diagnostics to match homme and to reduce probability of all_reduce calls due to mistakes in *nl files with statefreq.

oksanaguba commented 6 years ago

unit tests pass, also, cxx-F tests pass (I did not rebuild baselines):


      Start 51: prtcA-r3-dry-ne2-ndays1_cxx_vs_f90
18/24 Test #51: prtcA-r3-dry-ne2-ndays1_cxx_vs_f90 .....   Passed    0.42 sec
      Start 52: prtcB-r0-dry-ne2-ndays1_cxx_vs_f90
19/24 Test #52: prtcB-r0-dry-ne2-ndays1_cxx_vs_f90 .....   Passed    0.85 sec
      Start 53: prtcB-r3-dry-ne2-ndays1_cxx_vs_f90
20/24 Test #53: prtcB-r3-dry-ne2-ndays1_cxx_vs_f90 .....   Passed    0.83 sec
      Start 54: prtcA-r0-moist-ne2-ndays1_cxx_vs_f90
21/24 Test #54: prtcA-r0-moist-ne2-ndays1_cxx_vs_f90 ...   Passed    0.36 sec
      Start 55: prtcA-r3-moist-ne2-ndays1_cxx_vs_f90
22/24 Test #55: prtcA-r3-moist-ne2-ndays1_cxx_vs_f90 ...   Passed    0.35 sec
      Start 56: prtcB-r0-moist-ne2-ndays1_cxx_vs_f90
23/24 Test #56: prtcB-r0-moist-ne2-ndays1_cxx_vs_f90 ...   Passed    0.93 sec
      Start 57: prtcB-r3-moist-ne2-ndays1_cxx_vs_f90
24/24 Test #57: prtcB-r3-moist-ne2-ndays1_cxx_vs_f90 ...   Passed    0.87 sec```

This is ready for review.
oksanaguba commented 6 years ago

in filter_mod? it is not used at all and will never be.

ambrad commented 6 years ago

Somehow I missed the significance of this PR when I reviewed it. Very relieved to have this in xx so we don't make statefreq-related mistakes at scale. Thanks!