search

E3SM-Project / HOMMEXX

Clone of ACME for CMDV-SE project to convert HOMME to C++
11 stars 0 forks source link

add the NTESS copyright #319

Closed mfdeakin-sandia closed 6 years ago

mfdeakin-sandia commented 6 years ago

Fixes #318 Anything else I need to do?

ambrad commented 6 years ago

I think at minimum we also need

  1. The text following " In addition, the following complete language should also be included in the copyright notice:" in the email we received.
  2. The particular OSS license statement. Not sure which one, possibly BSD. Need to discuss with Andy.

Not sure whether we intend file-level header; also a topic for discussion.

bartgol commented 6 years ago

I think we should have a file-level header, which should simply refer to the main COPYRIGHT file for details. Something like

// + ----------------------------------------------------------------- +
// |   HOMMEXX 1.0: Copyright of Sandia Corporation                    | 
// |   This software is released under the BSD license                 |
// |   See the file 'COPYRIGHT' in the top-level HOMMEXX directory     |
// + ----------------------------------------------------------------- +

This is what Albany does, and I always thought it was nicer than the 40 lines header on top of each Trilinos header file...

mfdeakin-sandia commented 6 years ago

K, I've added the rest of the copyright (I just stopped reading after it said no other terms should be included...). I've also added the file level headers, though they're just copies of what's in the copyright file. @agsalin If you have a particular license which you know works with legal, let me know and I'll put it in (I have no preference here).

agsalin commented 6 years ago

3-clause BSD. Look at top level of CIME or E3SM or Albany,

ambrad commented 6 years ago

Looks good, but please wait for Andy's OK.

mfdeakin-sandia commented 6 years ago

That's the plan :+1: (I don't want legal to eat me!) I also copied the current copyright from the E3SM repo to the top level of this repo, just to be safe. Are there any issues or changes I should make? I'd be very happy if I could press the 'make public' button now and add the licensed tag to our references before sending our rebuttal

mfdeakin-sandia commented 6 years ago

though wait; that would break double blind... How does SC do reproducibility with double blind?

agsalin commented 6 years ago

(1) There seem to be 2 licenses concatenated. I want just the BSD. See CIME, but with just copyright 2018 NTESS. No export control, five years, NEITHER paragraphs

(2) As Luca said, I don't like the 60-line header per file. The 3-5 line one he suggested seems plenty good to me. Plus the full one at a higher level.

mfdeakin-sandia commented 6 years ago

I only have one license? I copied the one from CIME, removing all the copyright information. The source files have both the copyright and licensing. I'll change to the 3-5 lines