search

E3SM-Project / HOMMEXX

Clone of ACME for CMDV-SE project to convert HOMME to C++
11 stars 0 forks source link

Clean up a few files #321

Closed ambrad closed 6 years ago

ambrad commented 6 years ago

Looks like run1, run2, run_gpu_comparison.sh, and perhaps a few others got in by accident.

ambrad commented 6 years ago

Also, commits https://github.com/E3SM-Project/HOMMEXX/commit/acfd9593f547c0c99325fc421d95829ea9d532f0 through https://github.com/E3SM-Project/HOMMEXX/commit/987225e435f18cb53927abd3e3b44cfd90faab0f seem very strange.

Why all the hard-coded timers? They are expensive and so must be used selectively and only at a very high level. [Edit: Oh, I bet these commits somehow snuck in from the nvprof branch. Does it make sense simply to revert this sequence of commits?]

mfdeakin-sandia commented 6 years ago

Oh no, none of the commits from April and May are here... I'll fix it

mfdeakin-sandia commented 6 years ago

Looks fixed, sorry about that

ambrad commented 6 years ago

For the record, all the commits were here; there were just some spurious ones on top. Looks tidy now. Thanks!

mfdeakin-sandia commented 6 years ago

Really? I looked at the commits on github master I thought...

mfdeakin-sandia commented 6 years ago

Ah, I see, you're correct. I just had to look further down