search

E3SM-Project / HOMMEXX

Clone of ACME for CMDV-SE project to convert HOMME to C++
11 stars 0 forks source link

Fix #342 #353

Closed ambrad closed 6 years ago

ambrad commented 6 years ago

Fix use of a deprecated namespace for a function. Requires current Kokkos master, Kokkos SHA1 d3a941.

ambrad commented 6 years ago

This also fixes #342, as HOMMEXX builds now with undefined KOKKOS_ENABLE_DEPRECATED_CODE. (In the standalone Kokkos build with make, add --with-options=disable_deprecated_code to the generate_makefile.bash line to build with the symbol undefined.) I've modified the ride nightlies Kokkos build to exercise this. I'll do the same for bowman after the ride nightly succeeds at least once.

ambrad commented 6 years ago

There are a couple of View ctor issues revealed by turning off deprecated code, so I'm going to fix those and rerun tests.

ambrad commented 6 years ago

bowman and ride are now clean --with-options=disable_deprecated_code