search

E3SM-Project / a-prime

ACME Priority Metrics
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

Update to MPAS-Analysis v0.7.0 #29

Closed xylar closed 6 years ago

xylar commented 6 years ago

I just released MPAS-Analysis v0.7.0, so it would be great to have A-Prime support the new features included in this release.

There are some issues to discuss and some changes that will be needed.

Issues to discuss:

Changes:

kevans32 commented 6 years ago

Very cool. Would you need any help with testing/evaluation of this update? I think a phone call might be useful. We did want to support comparison's to a reference run but Dave was clear that we were not to do much development on A-PRIME, especially if its new plots that are specific for only certain runs/simulations. That said, I am sure if many folks want the feature he would be amenable.

xylar commented 6 years ago

I see. I agree, let's discuss. MPAS-Analysis certainly isn't going to cease development anytime soon so it will be important to know how our enhancements make their way into future E3SM runs if not through A-Prime.

milenaveneziani commented 6 years ago

I think what we definitely want is to point to the MPAS-Analysis html page and update things about the conda environment and the MOC region mask file. A-prime was designed to address the coupled model priority metrics: if people want to look more closely at the ocean and ice, they could just run MPAS-Analysis standalone. The comparison to a ref run is an open question: I am happy to address it in the next PR if people want it. @golaz: do you have an opinion on this? It will basically entail the running of a-prime (ocean only part) for the reference run first, and then a re-running to compare the test run with the reference run.

milenaveneziani commented 6 years ago

For the future, (and I have said this many times, sorry for repeating myself), these are the things we definitely want to update a-prime with: script to plot the online MOC and ocean-basin computations of OHC and SST,T, and S trends.

golaz commented 6 years ago

I would encourage you to have a discussion on how you envision that users will be calling A-Prime and MPAS-Analysis in the future. Should MPAS-Analysis be called as stand-alone package? Or should A-Prime be modified to (optionally?) call the full MPAS-Analysis, including the html interface?

I don't have a strong opinion either way. My hope is that ultimately all these packages would be incorporated and callable within the E3SM automated processflow.

kevans32 commented 6 years ago

agreed. @golaz could we have some time in the next coupled group call agenda to discuss? Or is it too jam packed with v1 activities that we should have a separate call just on this?

golaz commented 6 years ago

I'm not planning to have a water cycle coupled telecon this Monday. I'm only having them on a as-needed basis. We could have one specifically to discuss this, but it might be more productive to have the discussion within a smaller group involving key A-Prime and MPAS-Analysis developers. I don't have to be involved, but I can if you'd like.

xylar commented 6 years ago

It sounds like it might make sense to use one of LANL's special topic meeting slots to have this discussion. Those are at 10 am MST on Monday and Thursday. This coming week is bad for me because of the ALCC deadline on Thursday but the week after could work.

kevans32 commented 6 years ago

Next Monday the 5th works for me, but it needs to work for @salilmahajan as well.

milenaveneziani commented 6 years ago

If both a-prime and mpas-analysis are packages/softwares that are callable from the acme-process workflow package, then I personally think it doesn't make sense to have a-prime call mpas-analysis in full. A-prime was envisioned as a first analysis software to evaluate coupled models at first glance, with in-depth analysis left to component-specific analysis. It was also conceived as something that should not evolve much in time (except for making sure updated conda environments do not break the analysis, I guess). On the contrary, MPAS-Analysis is something that will continually evolve in time, as @xylar said, and will eventually be a package with the possibility to evaluate MPAS ocean and ice fields in a fairly complete way. Again, if both softwares can be called by the users through the acme-processing system, it seems OK to keep them separate. My 2 c.

salilmahajan commented 6 years ago

?Yes, Monday 5th works for me too! I am available all day.

Thanks,

Salil.

From: Kate Evans notifications@github.com Sent: Sunday, January 28, 2018 11:01 PM To: ACME-Climate/a-prime Cc: Mahajan, Salil; Mention Subject: Re: [ACME-Climate/a-prime] Update to MPAS-Analysis v0.7.0 (#29)

Next Monday the 5th works for me, but it needs to work for @salilmahajanhttps://github.com/salilmahajan as well.

- You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/ACME-Climate/a-prime/issues/29#issuecomment-361134596, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AH-jFTeROFsMRlsPFYKy4iLG67xGQwxvks5tPUKcgaJpZM4RusQ3.

kevans32 commented 6 years ago

All right 10MST it is, Mon Feb 5. Xylar is there a # you guys call into? Is it this part of a larger LANL group discussion at that time?

milenaveneziani commented 6 years ago

@kevans32 and all: let me create a meeting notes page on confluence and you will see the details of the call.

xylar commented 6 years ago

Thanks @milenaveneziani, that's perfect!

milenaveneziani commented 6 years ago

Apparently Feb 5 is already taken. We can also schedule a gotomeeting session without sitting in the same room. I have checked the gotomeeting calendar and it looks like gotomeeting2 is available on Th from 11am to 2pm (MST): would 11 or 12 or 1pm work for you this coming Th (Feb 1)? Next Th the 8th is too close to Ocean Sciences and I know I'll be in the midst of finishing up my poster..

xylar commented 6 years ago

This Thursday is the ALCC submission deadline so I don't want to commit to a meeting on that day. I agree that the following Thursday is also not good. What about another time on Monday?

milenaveneziani commented 6 years ago

Monday besides 10am doesn't work for me (I guess 3pm would work, but then it would be too late for the East coast). How about Tue Feb 6 at 10am? the gotomeeting2 session seems to be available.

xylar commented 6 years ago

That would work for me.

kevans32 commented 6 years ago

Tue-Thurs next week (Feb 6-8) I am at a local conference, but I could probably steal away, but just only at a couple of certain times, sorry. (all times are MST): I can do 2pm Feb 6, Wed or Thurs, anytime 8:30-11.

milenaveneziani commented 6 years ago

2pm Feb 6?

salilmahajan commented 6 years ago

?Sorry, I have a prior commitment on Wed. afternoon (Feb. 6). I can do Thursday.

From: Milena Veneziani notifications@github.com Sent: Tuesday, January 30, 2018 12:45 PM To: ACME-Climate/a-prime Cc: Mahajan, Salil; Mention Subject: Re: [ACME-Climate/a-prime] Update to MPAS-Analysis v0.7.0 (#29)

2pm Feb 6?

- You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/ACME-Climate/a-prime/issues/29#issuecomment-361674904, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AH-jFdyGObcWPMvcmnv9YXfRGmftT0wVks5tP1UxgaJpZM4RusQ3.

milenaveneziani commented 6 years ago

Feb 6 is Tue. Would Tue at 2pm MST work for you?

salilmahajan commented 6 years ago

?Oh. Yes, I can do that.

Thanks,

Salil.

From: Milena Veneziani notifications@github.com Sent: Tuesday, January 30, 2018 1:06 PM To: ACME-Climate/a-prime Cc: Mahajan, Salil; Mention Subject: Re: [ACME-Climate/a-prime] Update to MPAS-Analysis v0.7.0 (#29)

Feb 6 is Tue. Would Tue at 2pm MST work for you?

- You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/ACME-Climate/a-prime/issues/29#issuecomment-361681523, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AH-jFeHr4Oes2i-NLGUD75l-Gq47ZDPEks5tP1oXgaJpZM4RusQ3.

milenaveneziani commented 6 years ago

ok, @xylar said that works for him too.

See meeting notes page on confluence for call details: https://acme-climate.atlassian.net/wiki/spaces/OCNICE/pages/496435393/2018-02-06+Ocean+Ice+Special+Topics+coordination+MPAS-Analysis+A-prime

kevans32 commented 6 years ago

Is anyone on the call? I am sitting in there Gotomeeting lobby

pwolfram commented 6 years ago

People are on the call right now...

kevans32 commented 6 years ago

WHY AM I NOT ON!

xylar commented 6 years ago

@milenaveneziani, @kevans32 and @salilmahajan, I'm going to start working on a PR that would build a-prime as a package. It will depend on mpas_analysis as a package as well (specifying a specific version that it is compatible with).

To minimize other development work in a-prime before the next e3sm-unified release (which should include both mpas_analysis and a-prime as python packages), I think we should just focus on those changes needed to support existing a-prime capabilities with the newest MPAS-Analysis (rather than adding new plots or the capability to compare with a reference run). We can always follow up in the future with PRs that add a-prime support for new functionality.

milenaveneziani commented 6 years ago

Closing this, as we are updating to MPAS-Analysis v0.7.5 in #35 (and some of the issues mentioned ere are being addressed there).