E3SM-Project / e3sm_diags

E3SM Diagnostics package
https://e3sm-project.github.io/e3sm_diags
BSD 3-Clause "New" or "Revised" License
39 stars 32 forks source link

Explore refactoring of `acme.py` for readability and simplicity #716

Open tomvothecoder opened 1 year ago

tomvothecoder commented 1 year ago

The acme.py file is growing as more derived variables and formulas are being defined. We can explore implementation designs that might be more readable and extensible (e.g,. split file up into separate files).

Related code: https://github.com/E3SM-Project/e3sm_diags/blob/main/e3sm_diags/derivations/acme.py

Action Items:

Updates:

Notes from EZ Meeting on 8/30/23

So far in my CDAT migration PR, I split this file up into three files: formulas.py, derivations.py, and utils.py – Easier to maintain IMO, otherwise one file encapsulating everything will grow too large, can refactor some more in a separate PR

Look into e3sm_to_cmip solution for deriving variables and see if we can port to e3sm_diags since definitions and formulas should be the same