search

E3SM-Project / e3sm_diags

E3SM Diagnostics package
https://e3sm-project.github.io/e3sm_diags
BSD 3-Clause "New" or "Revised" License
38 stars 31 forks source link

[Bug]: CDAT Migration branch failing integration test due to regrid not maintaining correct units #785

Closed tomvothecoder closed 5 months ago

tomvothecoder commented 6 months ago

What happened?

The following plots differ because the variable's actual units are "mb" when the expected is "K":

What did you expect to happen? Are there are possible answers you came across?

This should be resolved by in PR #752, which includes a fix to maintain the variables units after regridding from hybrid to pressure levels.

Fix: https://github.com/E3SM-Project/e3sm_diags/pull/752#discussion_r1465463185

Minimal Complete Verifiable Example (MVCE)

No response

Relevant log output

No response

Anything else we need to know?

ERA-Interim-T-850-ANN-global

Actual:

ERA-Interim-T-850-ANN-global_actual

Expected: ERA-Interim-T-850-ANN-global_expected

Diff: ERA-Interim-T-850-ANN-global_diff

ERA-Interim-T-850-ANN-CONUS_RRM

Actual: ERA-Interim-T-850-ANN-CONUS_RRM_actual

Expected: ERA-Interim-T-850-ANN-CONUS_RRM_expected

Diff:

For some reason, the bottom plot has large diffs too. ERA-Interim-T-850-ANN-CONUS_RRM_diff

Environment

cdat_migration_fy24 branch

tomvothecoder commented 6 months ago

For some reason, the integration tests pass in CI/CD but not locally on perlmutter. For example, the build in PR #774 passes (link).

tomvothecoder commented 5 months ago

I think this is fixed now from recent merged commits.