rename() is not properly renaming original variable names to target derived variable keys. This bug has not been causing any issues in e3sm_diags and we don't write out files to netCDF (parameter.save_to_netcdf=False by default). This is a low priority issue and can be addressed when desired.
What happened?
rename()
is not properly renaming original variable names to target derived variable keys. This bug has not been causing any issues ine3sm_diags
and we don't write out files to netCDF (parameter.save_to_netcdf=False
by default). This is a low priority issue and can be addressed when desired.Technical Info
rename()
-- notice how it just returns whatever is passed to it (new_name
) https://github.com/E3SM-Project/e3sm_diags/blob/43f5f74057929c4bedddfab58be63f838ee36abe/e3sm_diags/derivations/acme.py#L19-L21Example
rename()
reference in derived vars dictionary -- the intended behavior is to rename "rsdt" to "SOLIN" https://github.com/E3SM-Project/e3sm_diags/blob/43f5f74057929c4bedddfab58be63f838ee36abe/e3sm_diags/derivations/acme.py#L674-L676Call to
rename()
-- notice that a cdms2.TransientVariable is being passed torename()
here.rename()
will just return that object without doing anything. https://github.com/E3SM-Project/e3sm_diags/blob/43f5f74057929c4bedddfab58be63f838ee36abe/e3sm_diags/driver/utils/dataset.py#L381-L386What did you expect to happen? Are there are possible answers you came across?
rename()
should update the.id
of thecdms2.TransientVariable
to the target keyExample:
Minimal Complete Verifiable Example (MVCE)
No response
Relevant log output
No response
Anything else we need to know?
No response
Environment
main
branch and all previous versions ofe3sm_diags
that usedrename()