Closed tomvothecoder closed 3 months ago
Yes, this is in earlier code. It still is concerning (though I don't think it is wrong or blocking to have this behavior). We can add a fix to avoid these errors, I would have hoped the logic wouldn't reach the units check in these cases...
Agreed. I think I commented on the wrong PR, the conversation should go to https://github.com/E3SM-Project/e3sm_diags/pull/805.. Sorry, Tom.
Agreed. I think I commented on the wrong PR, the conversation should go to #805.. Sorry, Tom.
No problem @chengzhuzhang. I moved the comments over to that PR and deleted them here.
"ANN" comparison -- no highlighted diffs
"JJA" comparison -- no highlighted diffs
Description
Todo
aerosol_budget_driver.py
aerosol_budget_plot.py
formulas.py
derivations.py
"hyai"
and"hybi"
toHYBRID_SIGMA_KEYS
and expand accepted valuesp0
,a_key
, andb_key
to_hybrid_to_pressure()
_hybrid_to_pressure()
to update units based onp0
get_name_yrs_attr()
inaerosol_aeronet_driver.py
5/8/24 Fixes
sum(x[0])
on derived variable with wildcards, which can actually have more than 1 element -- fixed by updating derived var function to expect a list of N variables and performsum()
within the functionmain
results did not have the fixes from PR #805, while this branch did. I re-ran the 2.90 example script again which produced the latestaerosol_budget
metrics that align with this branch (refer to results here)Checklist
If applicable: